Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #435 Invoking Query.Data(jsonObject:) fails for queries with params … #437

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Fixes #435 Invoking Query.Data(jsonObject:) fails for queries with params … #437

merged 2 commits into from
Jan 16, 2019

Conversation

diegorozen
Copy link
Contributor

#435

Adds an optional 'variables' parameter to pass to the executor

@apollo-cla
Copy link

@diegorozen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@martijnwalraven
Copy link
Contributor

Thanks! Would you mind adding a test for this? Just want to make sure we don't introduce any regressions in the future.

@diegorozen
Copy link
Contributor Author

@martijnwalraven Added a new test group. It includes testing a conditional query with and without params as well as a simpler query built from JsonObject. We could repeat all the tests from ParseQueryResponseTests to run through Query.Data(jsonObject:), but it seemed like an overkill

@martijnwalraven martijnwalraven merged commit c43f880 into apollographql:master Jan 16, 2019
@martijnwalraven
Copy link
Contributor

Thanks, this looks great!

@diegorozen diegorozen deleted the parameter_passing branch January 16, 2019 17:45
@diegorozen diegorozen restored the parameter_passing branch January 16, 2019 17:45
@diegorozen diegorozen deleted the parameter_passing branch January 18, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants